added src boolean to NetmaskGroupRule to match destination address #4116
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -779,8 +779,8 @@ vector<std::function<void(void)>> setupLua(bool client, const std::string& confi | |||
| return std::shared_ptr<DNSRule>(new SuffixMatchNodeRule(smn, quiet ? *quiet : false)); | |||
| }); | |||
|
|
|||
| g_lua.writeFunction("NetmaskGroupRule", [](const NetmaskGroup& nmg) { | |||
| return std::shared_ptr<DNSRule>(new NetmaskGroupRule(nmg)); | |||
| g_lua.writeFunction("NetmaskGroupRule", [](const NetmaskGroup& nmg, bool src = true) { | |||
There was a problem hiding this comment.
With the Lua wrapper we use, you need to make src a boost::optional<bool> if you want it to be optional, which is a good idea to keep compatibility. You'll then have to check whether it is set before using it. There is an example just above in SuffixMatchNodeRule.
|
I'm not sure what the use of the |
|
I believe that was my initial suggestion on IRC, but @cmouse made this suggestion which I went for. What to do now? |
|
Alright, it does not matter much, let's merge that. Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
In order to solve #4104, I've created this possible solution to the problem. Also split
NetmaskGroupRuleintoNMGRuleand its subclassNetmaskGroupRuleas @cmouse suggested.