auth: Don't try to deallocate empty PG statements #4206

Merged
merged 1 commit into from Jul 28, 2016

Projects

None yet

3 participants

@rgacogne
Member

When a SPgSQLStatement is released without having been prepared,
we execute an invalid 'DEALLOCATE ' SQL command. This might happen
if the statement has not been used before being destroyed, for example.
Fixes #4201.

@rgacogne rgacogne auth: Don't try to deallocate empty PG statements
When a SPgSQLStatement is released without having been prepared,
we execute an invalid 'DEALLOCATE ' SQL command. This might happen
if the statement has not been used before being destroyed, for example.
7ca4e21
@zeha
Collaborator
zeha commented Jul 19, 2016

Do we know /why/ this happens in the first place?

@rgacogne
Member

No, I upgraded my personal PowerDNS w/ PostgreSQL setup recently and I don't have the issue. I'd like to see if there is anything in the corresponding PowerDNS logs.

@pieterlexis pieterlexis merged commit 1a4908d into PowerDNS:master Jul 28, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@rgacogne rgacogne deleted the rgacogne:auth-psql-deallocate-4201 branch Jul 28, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment