Change DS config items to dsmap_t #4207

merged 2 commits into from Jul 29, 2016


None yet

2 participants


Ensure that addTA() appends the DS.

Closes #4200

This does have some code duplication though....

Habbie commented Jul 21, 2016

I don't see any deduplication of DSes, am I missing something?

@Habbie Habbie commented on an outdated diff Jul 29, 2016
@@ -47,7 +47,8 @@ add-nta *DOMAIN* [*REASON*]
: Add a Negative Trust Anchor for *DOMAIN*, suffixed optionally with *REASON*.
-: Add a Trust Anchor for *DOMAIN* with DS record data *DSRECORD*.
+: Add a Trust Anchor for *DOMAIN* with DS record data *DSRECORD*. This does not
+ replace the existing Trust Anchor for *DOMAIN* but appends the *DSRECORD*.
Habbie Jul 29, 2016 Member

This text comes across a bit vague. Maybe 'This adds the new TA to the existing TA set for the domain.' or the like

@Habbie Habbie commented on the diff Jul 29, 2016
@@ -101,8 +101,7 @@ GlobalStateHolder<LuaConfigItems> g_luaconfs;
auto ds=std::unique_ptr<DSRecordContent>(dynamic_cast<DSRecordContent*>(DSRecordContent::make("19036 8 2 49aac11d7b6f6446702e54a1607371607a1a41855200fd2ce1cdde32f24e8fb5")));
Habbie Jul 29, 2016 Member

not this PRs fault but we should really move 19036 into a central place.

pieterlexis Jul 29, 2016 Member

pdns/root_addresses.hh seems appropriate. This should be a new ticket

Habbie commented Jul 29, 2016


@pieterlexis pieterlexis merged commit ff6ca33 into PowerDNS:master Jul 29, 2016

1 check was pending

continuous-integration/travis-ci/pr The Travis CI build is in progress
@pieterlexis pieterlexis deleted the pieterlexis:multiple-DS-per-name branch Jul 29, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment