auth: better handling of invalid serial #4287

merged 3 commits into from Aug 15, 2016


None yet

2 participants

rgacogne commented Aug 5, 2016

Fixes #4281.

rgacogne added some commits Aug 4, 2016
@rgacogne rgacogne auth: Catch out_of_range exception when parsing serial 97ce13b
@rgacogne rgacogne auth: Handle out_of_range exception when parsing serial
Unsure if we can actually get a bad serial here, but we are checking
the number of parts so it looks like it might happen.
Habbie commented Aug 15, 2016

On the second commit: the pain is that we parse the wire format into text and then split it, which is terrible. In theory indeed we should not get out of range there but checking is good. One day we should stop making it text.

@Habbie Habbie merged commit 649c9bc into PowerDNS:master Aug 15, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
@rgacogne rgacogne deleted the rgacogne:auth-handle-bad-serial branch Aug 16, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment