Add options to LogAction() so it can append (instead of truncate) and… #4329
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… write without buffering. Was so happy to discover LogAction() but disappointed that it truncates the file each time the process starts, and apparently doesn't flush the file upon exiting. With two new optional args, the file can be appended rather than truncated and buffering disabled. The defaults remain as before, which is to say to truncate and to buffer.
| @@ -1257,7 +1257,7 @@ instantiate a server with additional parameters | |||
| * `DelayAction(milliseconds)`: delay the response by the specified amount of milliseconds (UDP-only) | |||
| * `DisableValidationAction()`: set the CD bit in the question, let it go through | |||
| * `DropAction()`: drop these packets | |||
| * `LogAction([filename], [binary])`: Log a line for each query, to the specified file if any, to the console (require verbose) otherwise. When logging to a file, the `binary` optional parameter specifies whether we log in binary form (default) or in textual form | |||
| * `LogAction([filename], [binary])`: Log a line for each query, to the specified file if any, to the console (require verbose) otherwise. When logging to a file, the `binary` optional parameter specifies whether we log in binary form (default) or in textual form, the `append` optional parameter specifies whether we open the file for appending or truncate each time (default), and the `buffered` optional parameter specifies whether writes to the file are buffered (default) or not. | |||
There was a problem hiding this comment.
The parameters have not been updated in the prototype here.
There was a problem hiding this comment.
Thanks, I missed that. Its added now.
added 2 commits
August 18, 2016 21:41
are only used in the constructor.
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… write without buffering.
Was so happy to discover LogAction() but disappointed that it truncates
the file each time the process starts, and apparently doesn't flush the
file upon exiting. With two new optional args, the file can be appended
rather than truncated and buffering disabled. The defaults remain as
before, which is to say to truncate and to buffer.