New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dnsdist: Fix building with clang on OS X and FreeBSD #4533

Merged
merged 2 commits into from Oct 24, 2016

Conversation

Projects
None yet
2 participants
@rgacogne
Member

rgacogne commented Oct 5, 2016

A big thanks to @cynthia!

Fixes #3552.

@rgacogne rgacogne added the dnsdist label Oct 5, 2016

@rgacogne

This comment has been minimized.

Member

rgacogne commented Oct 5, 2016

ace828b is also fixing compilation issue on the auth, so maybe I should split that PR.

@Habbie

This comment has been minimized.

Member

Habbie commented Oct 5, 2016

Perhaps upstream that one to luawrapper even, although I bet we are out of sync already?

rgacogne added some commits Oct 5, 2016

dnsdist: Use portable IPPROTO_TCP instead of SOL_TCP for TCP_FASTOPEN
This fixes the compilation on FreeBSD, where IPPROTO_TCP and
TCP_FASTOPEN are defined but SOL_TCP isn't.

@rgacogne rgacogne force-pushed the rgacogne:dnsdist-clang-bsd branch from f50e88b to 1654ece Oct 5, 2016

@rgacogne

This comment has been minimized.

Member

rgacogne commented Oct 5, 2016

The luawrapper fix from ace828b has been moved to #4537.

@rgacogne rgacogne added this to the dnsdist-1.1.0 milestone Oct 6, 2016

@Habbie Habbie merged commit eaed044 into PowerDNS:master Oct 24, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@rgacogne rgacogne deleted the rgacogne:dnsdist-clang-bsd branch Oct 25, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment