dnsdist: Fix insertion issues in SuffixMatchTree, move it to dnsname.hh #4541
Conversation
looks good to me. @Habbie ? |
Looks good. I do wonder if we could merge SMN/SMT? |
I just added a new issue for the SMN/SMT merge (#4761), merging this. |
rgacogne
added a commit
to rgacogne/pdns
that referenced
this pull request
Dec 12, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
No description provided.