improve dnsdist error message on a common typo/config mistake #4632

Merged
merged 1 commit into from Nov 9, 2016

Projects

None yet

2 participants

@ahupowerdns
Member
ahupowerdns commented Oct 25, 2016 edited

Short description

running newServer({"1.2.3.4", pool="primary"}) would produce a bloody useless error message.

Checklist

I have:

  • read the CONTRIBUTING.md document
  • compiled and tested this code
  • included documentation (including possible behaviour changes)
  • documented the code
  • added regression tests
  • added unit tests
  • checked that this code was merged to master

We improve the error in a pretty ugly way though.

The cause of the error is deep in the bowels of Lua and/or LuaWrapper. Even if we caught/fixed this error in a more karmic place, we'd still want to output this error message.

Also, dragons live there.

@ahupowerdns ahupowerdns with this commit we pretty up an otherwise bloody useless error on ty…
…ping: newServer({"1.2.3.4", pool="primary"}). We do so in a pretty ugly way though.

The cause of the error is deep in the bowels of Lua and/or LuaWrapper. Even if we caught/fixed this error in a more karmic place, we'd still want to output
this error message. Also, dragons live there.
98bac6b
@rgacogne rgacogne merged commit 100942d into PowerDNS:master Nov 9, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@Habbie Habbie referenced this pull request Jan 3, 2017
Open

prettify #4632 #4846

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment