New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

extract nested exception from Luawrapper #4646

Merged
merged 1 commit into from Nov 9, 2016

Conversation

Projects
None yet
4 participants
@Habbie
Member

Habbie commented Oct 28, 2016

Short description

This PR makes errors from inside Lua more visible in the log.

Checklist

I have:

  • read the CONTRIBUTING.md document
  • compiled and tested this code
  • included documentation (including possible behaviour changes)
  • documented the code
  • added regression tests
  • added unit tests
  • checked that this code was merged to master

Before:
Oct 28 15:30:34 STL error (www.foobar.com/A from 127.0.0.1): Exception thrown by a callback function called by Lua

After:
Oct 28 15:30:34 STL error (www.foobar.com/A from 127.0.0.1): Exception thrown by a callback function called by Lua. Extra info: Found . in wrong position in DNSName www.foobar.com..internal

reported by @elad, thanks!

extract nested exception from Luawrapper
Before:
Oct 28 15:30:34 STL error (www.foobar.com/A from 127.0.0.1): Exception thrown by a callback function called by Lua

After:
Oct 28 15:30:34 STL error (www.foobar.com/A from 127.0.0.1): Exception thrown by a callback function called by Lua. Extra info: Found . in wrong position in DNSName www.foobar.com..internal

reported by @elad, thanks!

@Habbie Habbie changed the title from extracted nested exception from Luawrapper to extract nested exception from Luawrapper Oct 28, 2016

@Habbie Habbie merged commit 9aa4c32 into PowerDNS:master Nov 9, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@Habbie Habbie deleted the Habbie:lua-except-unnest branch Nov 9, 2016

@elad

This comment has been minimized.

Show comment
Hide comment
@elad

elad Apr 19, 2017

Contributor

Hey @Habbie @rgacogne - any plans on backporting this to 4.0.x? we could really use this. :)

Contributor

elad commented Apr 19, 2017

Hey @Habbie @rgacogne - any plans on backporting this to 4.0.x? we could really use this. :)

@Habbie

This comment has been minimized.

Show comment
Hide comment
@Habbie

Habbie Apr 21, 2017

Member

@elad sure, but not high priority for us. Please feel free to ping occasionally, or perhaps file the PR yourself?

Member

Habbie commented Apr 21, 2017

@elad sure, but not high priority for us. Please feel free to ping occasionally, or perhaps file the PR yourself?

rgacogne added a commit to rgacogne/pdns that referenced this pull request Nov 13, 2017

@rgacogne rgacogne referenced this pull request Nov 13, 2017

Merged

Recursor 4.0.7 backports #5952

3 of 7 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment