New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bindbackend: do not corrupt data supplied by other backends in getAllDomains #4650

Merged
merged 2 commits into from Nov 11, 2016

Conversation

Projects
None yet
4 participants
@zeha
Collaborator

zeha commented Oct 29, 2016

Short description

Bindbackend previously tried to update the serial numbers of all domains passed to getAllDomains, even if it was not the original source of the domain. This breaks listing all domains in the API when both bind and gsqlite3 are configured, and the domain is stored in gsqlite3.

Fixes issue #4328.

Checklist

I have:

  • read the CONTRIBUTING.md document
  • compiled and tested this code
  • included documentation (including possible behaviour changes)
  • documented the code
  • added regression tests
  • added unit tests

@zeha zeha added this to the auth-4.1.0 milestone Oct 29, 2016

zeha added some commits Oct 29, 2016

Add test demonstrating issue #4328
Where, when bindbackend is loaded, serials show up as zero in domain listing.

@Habbie Habbie merged commit 1704035 into PowerDNS:master Nov 11, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@zeha zeha deleted the zeha:api-multibackend-serial0 branch Dec 8, 2016

@ahupowerdns ahupowerdns modified the milestone: auth-4.1.0 Feb 23, 2017

pieterlexis added a commit to pieterlexis/pdns that referenced this pull request Nov 7, 2017

pieterlexis added a commit to pieterlexis/pdns that referenced this pull request Nov 13, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment