Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dnsdist: Add statNodeRespRingSince(seconds, visitor) #4660

Closed

Conversation

rgacogne
Copy link
Member

@rgacogne rgacogne commented Nov 3, 2016

Short description

While statNodeRespRing() applies the visitor function to every entry in the response rings, statNodeRespRingSince() only applies it to entries added in the last seconds seconds.

I'd rather add an optional parameter to statNodeRespRing(), but I have been unable to successfully call a Lua function from statNodeRespRing() if the callback function is not the last parameter.

Checklist

I have:

  • read the CONTRIBUTING.md document
  • compiled and tested this code
  • added regression tests

While `statNodeRespRing()` applies the `visitor` function to every
entry in the response rings, `statNodeRespRingSince()` only applies
it to entries added in the last `seconds` seconds.

I'd rather add an optional parameter to `statNodeRespRing()`,
but I have been unable to successfully call a Lua function from
`statNodeRespRing()` if the callback function is not the last parameter.
@rgacogne rgacogne force-pushed the dnsdist-time-statnoderespring branch from 122d993 to b935db7 Compare December 8, 2016 17:17
@rgacogne rgacogne added this to the dnsdist-1.2.0 milestone Dec 14, 2016
@rgacogne
Copy link
Member Author

Closing this since #4775 should allow adding an optional parameter to statNodeRespRing() instead.

@rgacogne rgacogne closed this Dec 16, 2016
@rgacogne rgacogne deleted the dnsdist-time-statnoderespring branch October 22, 2021 09:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant