New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dnsdist: Add `statNodeRespRingSince(seconds, visitor)` #4660

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
1 participant
@rgacogne
Member

rgacogne commented Nov 3, 2016

Short description

While statNodeRespRing() applies the visitor function to every entry in the response rings, statNodeRespRingSince() only applies it to entries added in the last seconds seconds.

I'd rather add an optional parameter to statNodeRespRing(), but I have been unable to successfully call a Lua function from statNodeRespRing() if the callback function is not the last parameter.

Checklist

I have:

  • read the CONTRIBUTING.md document
  • compiled and tested this code
  • added regression tests

@rgacogne rgacogne force-pushed the rgacogne:dnsdist-time-statnoderespring branch from f7715de to 40afd04 Nov 30, 2016

@rgacogne rgacogne force-pushed the rgacogne:dnsdist-time-statnoderespring branch from 40afd04 to 122d993 Dec 8, 2016

dnsdist: Add `statNodeRespRingSince(seconds, visitor)`
While `statNodeRespRing()` applies the `visitor` function to every
entry in the response rings, `statNodeRespRingSince()` only applies
it to entries added in the last `seconds` seconds.

I'd rather add an optional parameter to `statNodeRespRing()`,
but I have been unable to successfully call a Lua function from
`statNodeRespRing()` if the callback function is not the last parameter.

@rgacogne rgacogne force-pushed the rgacogne:dnsdist-time-statnoderespring branch from 122d993 to b935db7 Dec 8, 2016

@rgacogne rgacogne added this to the dnsdist-1.2.0 milestone Dec 14, 2016

@rgacogne

This comment has been minimized.

Member

rgacogne commented Dec 16, 2016

Closing this since #4775 should allow adding an optional parameter to statNodeRespRing() instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment