Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upSpecify that dnsmessage.proto uses protobuf version 2 #4715
Conversation
rgacogne
added
backport to stable?
dnsdist
rec
labels
Nov 30, 2016
pieterlexis
merged commit 761aa6e
into
PowerDNS:master
Dec 9, 2016
1 check passed
continuous-integration/travis-ci/pr
The Travis CI build passed
Details
rgacogne
deleted the
rgacogne:dnsmessage-proto-set-version-2
branch
Dec 9, 2016
rgacogne
removed
the
backport to stable?
label
Dec 12, 2016
added a commit
that referenced
this pull request
Dec 13, 2016
Habbie
added
the
backport to stable?
label
Mar 21, 2017
rgacogne
removed
the
backport to stable?
label
Mar 21, 2017
Habbie
added
auth
backport to stable?
and removed
dnsdist
rec
labels
Mar 21, 2017
rgacogne
removed
the
backport to stable?
label
Nov 3, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
rgacogne commentedNov 30, 2016
Short description
Specify that dnsmessage.proto uses protobuf version 2, as recent proto-c versions are complaining loudly otherwise.
Checklist
I have: