/pdns

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dnsdist: Add the TCP socket to the map only if the connection succeeds #4734

Merged
merged 1 commit into from Dec 4, 2016

Conversation

Reviewers
No reviews
Assignees
No one assigned
Labels
defect dnsdist
Projects
None yet
Milestone
  dnsdist-1.1.0
2 participants
@rgacogne @ahupowerdns
@rgacogne
Member

rgacogne commented Dec 4, 2016

Short description

Otherwise we create a value-initialized (to 0) entry in the map and try to use it later, as reported by @philmayers and tracked down by @ahupowerdns in #4733.
Fixes #4733.

Checklist

I have:
@rgacogne
dnsdist: Add the TCP socket to the map only if the connection succeeds 
Otherwise we create a value-initialized (to 0) entry in the map and
try to use it later.
Loading status checks…
5a99e22

@rgacogne rgacogne added defect dnsdist labels Dec 4, 2016

@rgacogne rgacogne added this to the dnsdist-1.1.0 milestone Dec 4, 2016

@rgacogne rgacogne referenced this pull request Dec 4, 2016

Closed

dnsdist corrupts terminal when run in foreground #4733

@ahupowerdns ahupowerdns merged commit de08b9a into PowerDNS:master Dec 4, 2016
1 check passed

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@rgacogne rgacogne deleted the rgacogne:dnsdist-tcp-ssocket-exception branch Dec 5, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment