New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API: prevent sending nameservers list and zone-level NS in rrsets #4751

Merged
merged 1 commit into from Dec 13, 2016

Conversation

Projects
None yet
3 participants
@zeha
Collaborator

zeha commented Dec 8, 2016

Fixes #4132.

Prevent surprises when a user tries to mix nameservers as list and passes in a zone-level NS RRset too. This was previously part of #4195, but because that changes more I've split it out.

  • read the CONTRIBUTING.md document
  • compiled and tested this code
  • included documentation (including possible behaviour changes)
  • documented the code
  • added regression tests
  • added unit tests

@zeha zeha added auth rest-api labels Dec 8, 2016

@Habbie Habbie merged commit 1c8628f into PowerDNS:master Dec 13, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@zeha zeha deleted the zeha:api-decline-mixed-ns branch Dec 13, 2016

pieterlexis added a commit to pieterlexis/pdns that referenced this pull request Nov 7, 2017

pieterlexis added a commit to pieterlexis/pdns that referenced this pull request Nov 13, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment