Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SuffixMatchNode: Fix an insertion issue for an existing node #4762

Merged
merged 1 commit into from Dec 29, 2016

Conversation

@rgacogne
Copy link
Member

@rgacogne rgacogne commented Dec 12, 2016

Short description

If the node we are about to insert already existed as an intermediary one, we need to mark it as an end node.

Checklist

I have:

  • read the CONTRIBUTING.md document
  • compiled and tested this code
  • added unit tests
If the node we are about to insert already existed as an intermediary
one, we need to mark it as an end node.
@rgacogne rgacogne modified the milestones: dnsdist-1.2.0, dnsdist-1.1.0 Dec 14, 2016
@rgacogne rgacogne merged commit c2fb8f5 into PowerDNS:master Dec 29, 2016
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@rgacogne rgacogne deleted the rgacogne:suffixmatchnode-existing-node branch Dec 29, 2016
pieterlexis added a commit that referenced this pull request Feb 16, 2017
Backport #4762: SuffixMatchNode: Fix insertion issue for an existing node (auth)
pieterlexis added a commit that referenced this pull request Feb 16, 2017
Backport #4762: SuffixMatchNode: Fix insertion issue for an existing node (rec)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.