Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LuaWrapper: Use the correct index when storing a function #4775

Merged
merged 2 commits into from Jan 13, 2017

Conversation

@rgacogne
Copy link
Member

@rgacogne rgacogne commented Dec 16, 2016

Short description

The LuaWrapper used to assume that the function was at the top of the stack, making it effectively impossible to have a callback function parameter anywhere else than as the last parameter.

Checklist

I have:

The LuaWrapper used to assume that the function was at the
top of the stack, making it effectively impossible to have
a callback function parameter anywhere else than as the last
parameter.
@Habbie
Habbie approved these changes Dec 16, 2016
@@ -1642,10 +1642,10 @@ class LuaContext {
// structure that will ensure that a certain is stored somewhere in the registry
struct ValueInRegistry {
// this constructor will clone and hold the value at the top of the stack in the registry

This comment has been minimized.

@Habbie

Habbie Dec 16, 2016
Member

This comment is now wrong?

@@ -1642,10 +1642,10 @@ class LuaContext {
// structure that will ensure that a certain is stored somewhere in the registry

This comment has been minimized.

@Habbie

Habbie Dec 16, 2016
Member

This comment already was wrong ;)

@pieterlexis pieterlexis merged commit 75226d5 into PowerDNS:master Jan 13, 2017
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@rgacogne rgacogne deleted the rgacogne:luawrapper-func-index branch Jan 13, 2017
pieterlexis added a commit that referenced this pull request Feb 16, 2017
Backport #4775: LuaWrapper: Use the correct index when storing a function
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.