Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign updnsdist: Save history to home-dir #4779
Conversation
pieterlexis
added
backport to stable?
dnsdist
needs review
labels
Dec 16, 2016
pieterlexis
assigned
rgacogne
Dec 16, 2016
pieterlexis
force-pushed the
pieterlexis:dnsdist-history-to-home
branch
3 times, most recently
from
a4d8d99
to
936c472
Dec 16, 2016
pdns/dnsdist-console.cc
Outdated
| struct passwd pwd; | ||
| struct passwd *result; | ||
| char buf[16384]; | ||
| getpwuid_r(getuid(), &pwd, buf, sizeof(buf), &result); |
This comment has been minimized.
This comment has been minimized.
rgacogne
Dec 20, 2016
Member
I'm wondering if we should use geteuid() instead, in the unlikely event dnsdist is started with -u while in foreground mode.
pdns/dnsdist-console.cc
Outdated
| ret = string(pwd.pw_dir); | ||
| if (homedir && !ignoreHOME) // $HOME overrides what the OS tells us | ||
| ret = string(homedir); | ||
| ret.append("/.dnsdist_history"); |
This comment has been minimized.
This comment has been minimized.
rgacogne
Dec 20, 2016
Member
How about not setting ret to "." beforehand and testing here if it's empty? If it is (somehow $HOME or pwd.pw_dir were empty or nothing worked), we could then fallback to "." before appending "/.dnsdist_history". This would prevent trying to write in "/.dnsdist_history".
pieterlexis
force-pushed the
pieterlexis:dnsdist-history-to-home
branch
from
936c472
to
9364403
Dec 20, 2016
pieterlexis
merged commit 6f3c797
into
PowerDNS:master
Jan 13, 2017
1 check passed
continuous-integration/travis-ci/pr
The Travis CI build passed
Details
pieterlexis
deleted the
pieterlexis:dnsdist-history-to-home
branch
Jan 13, 2017
rgacogne
removed
the
backport to stable?
label
Nov 21, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
pieterlexis commentedDec 16, 2016
Short description
Only use CWD as a last resort. This prevents cluttering directories with
.dnsdist_historyfilesCloses #4562
Checklist
I have: