Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dnsdist: Add an optional `seconds` parameter to `statNodeRespRing()` #4780

Merged

Conversation

@rgacogne
Copy link
Member

@rgacogne rgacogne commented Dec 17, 2016

Short description

By default statNodeRespRing() applies the visitor function to every entry in the responses ring. When passed a non-zero seconds parameter, it will only apply it to entries added in the last seconds seconds.
Based on top of #4775, replaces #4660.

Checklist

I have:

  • read the CONTRIBUTING.md document
  • compiled and tested this code
  • added regression tests
@rgacogne rgacogne added this to the dnsdist-1.2.0 milestone Dec 17, 2016
@pieterlexis
Copy link
Member

@pieterlexis pieterlexis commented Jan 13, 2017

I think commit 4ec1e17 was already merged in #4775?

By default `statNodeRespRing()` applies the visitor function to every
entry in the response rings. When passed a non-zero `seconds` parameter,
it will only apply it to entries added in the last `seconds` seconds.
@rgacogne rgacogne force-pushed the rgacogne:dnsdist-optional-time-statnoderespring branch from 1a859c8 to 26b86de Jan 13, 2017
@rgacogne
Copy link
Member Author

@rgacogne rgacogne commented Jan 13, 2017

Indeed, rebased!

@rgacogne rgacogne merged commit 66069dd into PowerDNS:master Jan 19, 2017
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@rgacogne rgacogne deleted the rgacogne:dnsdist-optional-time-statnoderespring branch Jan 19, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.