New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dnsdist: Send a latency of 0 over carbon, null over API for down servers #4785

Merged
merged 1 commit into from Jan 19, 2017

Conversation

Projects
None yet
1 participant
@rgacogne
Member

rgacogne commented Dec 19, 2016

Short description

It makes no sense to send the previous latency for a server that we know to be down. This PR sends 0 over carbon since I don't know of a better way to signal that the value is not set. Not sending the value at all when a server is down results in very weird graphs.
Closes #4689.

Checklist

I have:

  • read the CONTRIBUTING.md document
  • compiled and tested this code
  • added regression tests

@rgacogne rgacogne added this to the dnsdist-1.2.0 milestone Dec 19, 2016

@rgacogne rgacogne merged commit 1638ca3 into PowerDNS:master Jan 19, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@rgacogne rgacogne deleted the rgacogne:dnsdist-down-latency branch Jan 19, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment