dnsdist: Handle header-only responses, handle Refused as Servfail in the cache #4812
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@rygl reported that unbound at least sends `Refused` responses containing only the DNS header.
The check is done before inserting the response into the cache, but it feels safer to check it again before passing it to `memcpy()`. We check that the cached response is larger than `sizeof(dnsheader) + qname` afterwards, but the previous commit moved the header copy before that check.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short description
@rygl reported that
UnboundsendsRefusedresponses containing only the DNS header, and that we didn't parse these correctly.This patch also makes the packet cache use the same custom
TTLforRefusedresponses than forServFailones.Checklist
I have: