/pdns

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dnsdist: Handle header-only responses, handle Refused as Servfail in the cache #4812

Merged
merged 3 commits into from Dec 29, 2016

Conversation

Reviewers
No reviews
Assignees
No one assigned
Labels
defect dnsdist
Projects
None yet
Milestone
  dnsdist-1.1.0
1 participant
@rgacogne
@rgacogne
Member

rgacogne commented Dec 23, 2016

Short description

@rygl reported that Unbound sends Refused responses containing only the DNS header, and that we didn't parse these correctly.
This patch also makes the packet cache use the same custom TTL for Refused responses than for ServFail ones.

Checklist

I have:

  • read the CONTRIBUTING.md document
  • compiled and tested this code
  • included documentation (including possible behaviour changes)
  • documented the code
  • added regression tests

rgacogne added some commits Dec 22, 2016

@rgacogne
dnsdist: Handle responses with qdcount == 0 
@rygl reported that unbound at least sends `Refused` responses
containing only the DNS header.
c8c3d4e
@rgacogne
dnsdist: Handle Refused as ServFail in the packet cache
Loading status checks…
2714396

@rgacogne rgacogne added defect dnsdist labels Dec 23, 2016

@rgacogne rgacogne added this to the dnsdist-1.1.0 milestone Dec 23, 2016

@rgacogne
dnsdist: Check that cached responses are >= sizeof(dnsheader) 
The check is done before inserting the response into the cache, but
it feels safer to check it again before passing it to `memcpy()`.
We check that the cached response is larger than
`sizeof(dnsheader) + qname` afterwards, but the previous commit
moved the header copy before that check.
Loading status checks…
39a2197

@rgacogne rgacogne merged commit 2ea1f87 into PowerDNS:master Dec 29, 2016
1 check passed

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@rgacogne rgacogne deleted the rgacogne:dnsdist-qdcount-zero-responses branch Dec 29, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment