/pdns

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DNSCrypt: Store the computed shared key and reuse it for the response #4813

Merged
merged 3 commits into from Jan 19, 2017

Conversation

Reviewers
No reviews
Assignees
No one assigned
Labels
dnsdist enhancement
Projects
None yet
Milestone
  dnsdist-1.2.0
1 participant
@rgacogne
@rgacogne
Member

rgacogne commented Dec 23, 2016

Short description

Instead of computing the shared-key derived from the public and private keys twice -when decrypting the query and when encrypting the response- we now store and reuse the shared key.

Checklist

I have:

rgacogne added some commits Dec 23, 2016

@rgacogne
DNSCrypt: Store the computed shared-key and reuse it for the response 
Instead of computing the shared-key derived from the public and private
keys twice -when decrypting the query and when encrypting the response-
we now store and reuse the shared key.
332fdc5
@rgacogne
DNSCrypt: Don't call `sodium_memzero()` right before `sodium_munlock()` 
The documentation states that `sodium_munlock()` will properly zero
the memory before making it swappable, so we don't need to call
`sodium_memzero()` ourselves.
d225663
@rgacogne
DNSCrypt: Only lock the shared key memory if we use it
Loading status checks…
8089cbe

@rgacogne rgacogne added dnsdist enhancement labels Dec 23, 2016

@rgacogne rgacogne added this to the dnsdist-1.2.0 milestone Dec 23, 2016

@rgacogne rgacogne merged commit aaa3150 into PowerDNS:master Jan 19, 2017
1 check passed

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@rgacogne rgacogne deleted the rgacogne:dnscrypt-after-nm branch Jan 19, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment