DNSCrypt: Store the computed shared key and reuse it for the response #4813
Conversation
Instead of computing the shared-key derived from the public and private keys twice -when decrypting the query and when encrypting the response- we now store and reuse the shared key.
The documentation states that `sodium_munlock()` will properly zero the memory before making it swappable, so we don't need to call `sodium_memzero()` ourselves.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Short description
Instead of computing the shared-key derived from the public and private keys twice -when decrypting the query and when encrypting the response- we now store and reuse the shared key.
Checklist
I have: