Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dnsdist: Add tcpConnectTimeout to newServer() #4818

Merged
merged 1 commit into from Jan 20, 2017

Conversation

rgacogne
Copy link
Member

Short description

While we already had timeouts when writing to or reading from TCP backends, the initial connection attempt was blocking. In addition to that, if the connection to the backend failed we didn't retry and simply closed the corresponding connection to the client. We now retry up to retries times,
as we did for I/O errors.

Checklist

I have:

  • read the CONTRIBUTING.md document
  • compiled and tested this code
  • included documentation (including possible behaviour changes)
  • documented the code

While we already timeouts when writing to or reading from TCP backends,
the initial connection attempt was blocking. In addition to that, if the
connection to the backend failed we didn't retry and simply closed the
corresponding connection to the client. We now retry up to `retries` times,
as we did for I/O errors.
@rgacogne rgacogne merged commit c69c3e2 into PowerDNS:master Jan 20, 2017
@rgacogne rgacogne deleted the dnsdist-connect-timeout branch January 20, 2017 10:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant