New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dnsdist: Add `tcpConnectTimeout` to `newServer()` #4818

Merged
merged 1 commit into from Jan 20, 2017

Conversation

Projects
None yet
1 participant
@rgacogne
Member

rgacogne commented Dec 23, 2016

Short description

While we already had timeouts when writing to or reading from TCP backends, the initial connection attempt was blocking. In addition to that, if the connection to the backend failed we didn't retry and simply closed the corresponding connection to the client. We now retry up to retries times,
as we did for I/O errors.

Checklist

I have:

  • read the CONTRIBUTING.md document
  • compiled and tested this code
  • included documentation (including possible behaviour changes)
  • documented the code
dnsdist: Add `tcpConnectTimeout` to `newServer()`
While we already timeouts when writing to or reading from TCP backends,
the initial connection attempt was blocking. In addition to that, if the
connection to the backend failed we didn't retry and simply closed the
corresponding connection to the client. We now retry up to `retries` times,
as we did for I/O errors.

@rgacogne rgacogne force-pushed the rgacogne:dnsdist-connect-timeout branch from 788df63 to b40cffe Jan 19, 2017

@rgacogne rgacogne merged commit c69c3e2 into PowerDNS:master Jan 20, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@rgacogne rgacogne deleted the rgacogne:dnsdist-connect-timeout branch Jan 20, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment