New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DNSName: Check that both first two bits are set in compressed labels #4852

Merged
merged 1 commit into from Jan 10, 2017

Conversation

Projects
None yet
2 participants
@rgacogne
Member

rgacogne commented Jan 4, 2017

Short description

We checked that at least one of the first two bits was set, but the 10 and 01 are combinations do not indicate a compressed label and are reserved for future use.
Fixes #4851.

Checklist

I have:

  • read the CONTRIBUTING.md document
  • compiled and tested this code
  • included documentation (including possible behaviour changes)
  • documented the code
  • added regression tests
  • added unit tests
  • checked that this code was merged to master
DNSName: Check that both first two bits are set in compressed labels
We checked that at least one of the first two bits was set,
but the 10 and 01 are combinations do not indicate a compressed label
and are reserved for future use.

@pieterlexis pieterlexis merged commit 8d90f90 into PowerDNS:master Jan 10, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@rgacogne rgacogne deleted the rgacogne:issue-4851 branch Jan 10, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment