New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

It turns out our use of getaddrinfo in communicator.hh would be retur… #4855

Merged
merged 1 commit into from Jan 10, 2017

Conversation

Projects
None yet
2 participants
@ahupowerdns
Member

ahupowerdns commented Jan 4, 2017

…ning all addresses in triplicate (one for each socket type). See https://bugzilla.mozilla.org/show_bug.cgi?id=223811

We may have filtered this out at a later stage, but it was wrong in any case.

Short description

When looking up IPv4 or IPv6 addresses to notify in the communicator class, getaddrinfo would give us all addresses in triplicate.

Checklist

I have:

  • read the CONTRIBUTING.md document
  • compiled and tested this code
  • included documentation (including possible behaviour changes)
  • documented the code
  • added regression tests
  • added unit tests
  • checked that this code was merged to master
It turns out our use of getaddrinfo in communicator.hh would be retur…
…ning all addresses in triplicate (one for each socket type). See https://bugzilla.mozilla.org/show_bug.cgi?id=223811

We may have filtered this out at a later stage, but it was wrong in any case.

@pieterlexis pieterlexis merged commit c069357 into PowerDNS:master Jan 10, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@ahupowerdns ahupowerdns deleted the ahupowerdns:getaddrinfo-triplicate branch Sep 19, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment