Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change truncateTC to defaulting to off #4859

Merged

Conversation

@RobinGeuze
Copy link
Contributor

@RobinGeuze RobinGeuze commented Jan 6, 2017

Short description

Having truncateTC enabled by default causes dnsdist to break compatibility with RFC 6891 by default. Closes #4857

Checklist

I have:

  • read the CONTRIBUTING.md document
  • compiled and tested this code
  • included documentation (including possible behaviour changes)
  • documented the code
…with RFC6891 and is generally not needed
@@ -1406,7 +1406,7 @@ instantiate a server with additional parameters
* `addDelay(netmask, n)`: delay answers within that netmask by n milliseconds
* `addDelay({netmask, netmask}, n)`: delay answers within those netmasks (together) by n milliseconds
* Answer changing functions:
* `truncateTC(bool)`: if set (default) truncate TC=1 answers so they are actually empty. Fixes an issue for PowerDNS Authoritative Server 2.9.22.
* `truncateTC(bool)`: if set (default to no) truncate TC=1 answers so they are actually empty. Fixes an issue for PowerDNS Authoritative Server 2.9.22. Note: turning this on breaks compatibility with RFC 6891.

This comment has been minimized.

@pieterlexis

pieterlexis Jan 6, 2017
Member

"Defaults to no starting with dnsdist 1.2.0"

@rgacogne rgacogne added the dnsdist label Jan 6, 2017
@rgacogne rgacogne added this to the dnsdist-1.2.0 milestone Jan 6, 2017
Make it more concise specifying when the default behaviour changed.
Copy link
Member

@rgacogne rgacogne left a comment

Two nits, LGTM otherwise.

@@ -366,7 +366,7 @@ const std::vector<ConsoleKeyword> g_consoleKeywords{
{ "topResponseRule", true, "", "move the last response rule to the first position" },
{ "topRule", true, "", "move the last rule to the first position" },
{ "topSlow", true, "[top][, limit][, labels]", "show `top` queries slower than `limit` milliseconds, grouped by last `labels` labels" },
{ "truncateTC", true, "bool", "if set (default) truncate TC=1 answers so they are actually empty. Fixes an issue for PowerDNS Authoritative Server 2.9.22" },
{ "truncateTC", true, "bool", "if set (defaults to no starting with dnsdist 1.2.0) truncate TC=1 answers so they are actually empty. Fixes an issue for PowerDNS Authoritative Server 2.9.22. Note: turning this one breaks compatibility with RFC 6891." },

This comment has been minimized.

@rgacogne

rgacogne Jan 6, 2017
Member

s/turning this one/turning this on/

This comment has been minimized.

@RobinGeuze

RobinGeuze Jan 6, 2017
Author Contributor

Fixed

@@ -136,7 +136,7 @@ int g_tcpSendTimeout{2};
int g_udpTimeout{2};

bool g_servFailOnNoPolicy{false};
bool g_truncateTC{1};
bool g_truncateTC{0};

This comment has been minimized.

@rgacogne

rgacogne Jan 6, 2017
Member

I know we use 0 or 1 in other places, but I'd prefer you use false here.

This comment has been minimized.

@RobinGeuze

RobinGeuze Jan 6, 2017
Author Contributor

Fixed

@pieterlexis pieterlexis merged commit fdc1545 into PowerDNS:master Jan 30, 2017
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.