New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

optimize only-notify logic v2 #4861

Merged
merged 2 commits into from Jan 30, 2017

Conversation

Projects
None yet
4 participants
@klaus3000

klaus3000 commented Jan 8, 2017

A new try to fix the issues (see #3890). This time only the logic fixed, not the logging.

@rgacogne

This comment has been minimized.

Show comment
Hide comment
@rgacogne

rgacogne Jan 9, 2017

Member

Travis tests failed because of a broken jdnssec link fixed in #4862, rebasing to master should fix that.

Member

rgacogne commented Jan 9, 2017

Travis tests failed because of a broken jdnssec link fixed in #4862, rebasing to master should fix that.

Klaus Darilion
Do not resolve the NS-records for NOTIFY targets if the "only-notify"…
… whitelist is empty, as a target will never match an empty whitelist.
@klaus3000

This comment has been minimized.

Show comment
Hide comment
@klaus3000

klaus3000 Jan 9, 2017

Rebased. Ready to accept :)

klaus3000 commented Jan 9, 2017

Rebased. Ready to accept :)

@Habbie Habbie merged commit 3869550 into PowerDNS:master Jan 30, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@klaus3000 klaus3000 deleted the klaus3000:master-optimize-only-notify branch Jan 30, 2017

pieterlexis added a commit that referenced this pull request Feb 16, 2017

Merge pull request #5015 from pieterlexis/backport-4861
Backport #4861: Do not resolve the NS-records for NOTIFY targets if the "only-notify"…
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment