New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix AtomicCounter unit tests on 32-bit #4901

Merged
merged 1 commit into from Jan 24, 2017

Conversation

Projects
None yet
2 participants
@rgacogne
Member

rgacogne commented Jan 13, 2017

Short description

Our unit tests were broken on 32-bit since AtomicCounter was moved to a std::atomic<unsigned long>.

Checklist

I have:

  • read the CONTRIBUTING.md document
  • compiled and tested this code
  • included documentation (including possible behaviour changes)
  • documented the code
  • added regression tests
  • added unit tests

@pieterlexis pieterlexis merged commit a8e8403 into PowerDNS:master Jan 24, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@rgacogne rgacogne deleted the rgacogne:atomic-counter-32 branch Jan 24, 2017

pieterlexis added a commit that referenced this pull request Feb 17, 2017

Merge pull request #4934 from rgacogne/auth40-backport-4901
Backport #4901: Fix AtomicCounter unit tests on 32-bit
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment