Revert "auth: In `Bind2Backend::lookup()`, use the `zoneId` when we have it" #4905

Merged
merged 1 commit into from Jan 16, 2017

Projects

None yet

3 participants

@rgacogne
Member

Short description

This reverts commit 937a662.
It doesn't work with multiple backends since the zoneId is passed to
every available backend on lookup().

Checklist

I have:

  • read the CONTRIBUTING.md document
  • compiled and tested this code
  • included documentation (including possible behaviour changes)
  • documented the code
  • added regression tests
  • added unit tests
@rgacogne rgacogne Revert "auth: In `Bind2Backend::lookup()`, use the `zoneId` when we h…
…ave it"

This reverts commit 937a662.
It doesn't work with multiple backends since the `zoneId` is passed to
every available backend on `lookup()`.
98b9845
@zeha
Collaborator
zeha commented Jan 15, 2017

IMO this would be okay on master if the check also did a suffix match on qname. Then it's as good/bad as gsql.

@pieterlexis pieterlexis merged commit c5414ea into PowerDNS:master Jan 16, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@rgacogne rgacogne deleted the rgacogne:revert-4638 branch Jan 18, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment