New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tidy up UeberBackend a bit #4908

Merged
merged 2 commits into from Jan 23, 2017

Conversation

Projects
None yet
2 participants
@zeha
Collaborator

zeha commented Jan 14, 2017

Short description

Code cleanup only. May improve compilation times.

Checklist

I have:

  • read the CONTRIBUTING.md document
  • compiled
  • and tested this code
  • included documentation (including possible behaviour changes)
  • documented the code
  • added regression tests
  • added unit tests

@zeha zeha added the auth label Jan 14, 2017

@Habbie

Habbie approved these changes Jan 23, 2017

@@ -22,6 +22,9 @@
#ifdef HAVE_CONFIG_H
#include "config.h"
#endif
#include <sys/types.h>
#include <sys/socket.h>
#include <sys/un.h>

This comment has been minimized.

@Habbie

Habbie Jan 23, 2017

Member

commit message does not mention this - was this added intentionally?

@Habbie

Habbie Jan 23, 2017

Member

commit message does not mention this - was this added intentionally?

This comment has been minimized.

@zeha

zeha Jan 23, 2017

Collaborator

they used to be in ueberbackend.hh, but nothing else appears to need them.

@zeha

zeha Jan 23, 2017

Collaborator

they used to be in ueberbackend.hh, but nothing else appears to need them.

This comment has been minimized.

@Habbie

Habbie Jan 23, 2017

Member

Ah yes, works for me.

@Habbie

Habbie Jan 23, 2017

Member

Ah yes, works for me.

@@ -29,6 +29,7 @@
#include "utility.hh"
#include <dlfcn.h>

This comment has been minimized.

@Habbie

Habbie Jan 23, 2017

Member

was this added intentionally?

@Habbie

Habbie Jan 23, 2017

Member

was this added intentionally?

This comment has been minimized.

@zeha

zeha Jan 23, 2017

Collaborator

this was just moved from ueberbackend.hh

@zeha

zeha Jan 23, 2017

Collaborator

this was just moved from ueberbackend.hh

This comment has been minimized.

@Habbie

Habbie Jan 23, 2017

Member

👍

@Habbie

@Habbie Habbie merged commit 128c061 into PowerDNS:master Jan 23, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@zeha zeha deleted the zeha:ubercleanup branch Jan 23, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment