Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.Sign up
GitHub is where the world builds software
Millions of developers and companies build, ship, and maintain their software on GitHub — the largest and most advanced development platform in the world.
Fix negative port detection for IPv6 addresses on 32-bit #4911
On a 32-bit Arch, our
On a 32-bit Arch, our `test_ComboAddress` unit test fails because `ComboAddress("[::1]:-6")` is considered valid. This is caused by `stoul()` not throwing for a negative value and returning an `unsigned long` value using unsigned integer wraparound rules. Since we used to store the result value in a `signed int` and treat negative values as if the port was not set, the test failed.