/ pdns Public
Fix negative port detection for IPv6 addresses on 32-bit #4911
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge.
On a 32-bit Arch, our
test_ComboAddressunit test fails because
ComboAddress("[::1]:-6")is considered valid. This is caused by
stoul()not throwing for a negative value and returning an
unsigned longvalue using unsigned integer wraparound rules. Since we used to store the result value in a
signed intand treat negative values as if the port was not set, the test failed.