Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Register DNSName::chopOff in lua #4920

merged 3 commits into from Feb 24, 2017

Register DNSName::chopOff in lua #4920

merged 3 commits into from Feb 24, 2017


Copy link

@plzz plzz commented Jan 18, 2017

Short description

Register DNSName::chopOff in lua
> foo = newDNSName("")
> foo:toString()
> foo:chopOff()
Command returned an object we can't print
> foo:toString()


I have:

  • read the document
  • compiled and tested this code
  • included documentation (including possible behaviour changes)
  • documented the code
  • added regression tests
  • added unit tests
  • checked that this code was merged to master
@@ -1460,6 +1460,7 @@ instantiate a server with additional parameters
* `truncate(bits)`: truncate the address to the specified number of bits
* DNSName related:
* `newDNSName(name)`: make a DNSName based on this .-terminated name
* member `chopOff()`: remove left-most label

This comment has been minimized.


Habbie Jan 23, 2017

Please document the return value. I find myself using that a lot when writing Lua for the recursor.

Copy link

@rgacogne rgacogne commented Feb 20, 2017

Ping? If you document the return value I'll happily merge this!

@rgacogne rgacogne merged commit 2ba7770 into PowerDNS:master Feb 24, 2017
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
@plzz plzz deleted the plzz:chopoff branch Feb 25, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants