Register DNSName::chopOff in lua#4920
Merged
rgacogne merged 3 commits intoPowerDNS:masterfrom Feb 24, 2017
Merged
Conversation
Habbie
requested changes
Jan 23, 2017
pdns/README-dnsdist.md
Outdated
| * `truncate(bits)`: truncate the address to the specified number of bits | ||
| * DNSName related: | ||
| * `newDNSName(name)`: make a DNSName based on this .-terminated name | ||
| * member `chopOff()`: remove left-most label |
Member
There was a problem hiding this comment.
Please document the return value. I find myself using that a lot when writing Lua for the recursor.
Member
|
Ping? If you document the return value I'll happily merge this! |
rgacogne
approved these changes
Feb 24, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Short description
Register DNSName::chopOff in lua
> foo = newDNSName("foo.com")> foo:toString()foo.com.> foo:chopOff()Command returned an object we can't print> foo:toString()com.Checklist
I have: