New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix ldap-strict autoptr feature, including a test #4922

Merged
merged 4 commits into from Feb 21, 2017

Conversation

Projects
None yet
4 participants
@Habbie
Member

Habbie commented Jan 18, 2017

No description provided.

@Habbie

This comment has been minimized.

Show comment
Hide comment
@Habbie

Habbie Jan 18, 2017

Member

Fixes #3165

Member

Habbie commented Jan 18, 2017

Fixes #3165

@zeha

This comment has been minimized.

Show comment
Hide comment
@zeha

zeha Jan 18, 2017

Collaborator

do we need to init m_qtype in ctor

No. Calling ::get before ::lookup is wrong and broken, so having that uninit' is fine. (Actually, gsql would deref a nullptr in that path...)

Collaborator

zeha commented Jan 18, 2017

do we need to init m_qtype in ctor

No. Calling ::get before ::lookup is wrong and broken, so having that uninit' is fine. (Actually, gsql would deref a nullptr in that path...)

@Habbie Habbie changed the title from WIP fix strict mode autoptr, NEEDS WHITESPACE FIX, do we need to init m_qtype in ctor? to fix ldap-strict autoptr feature, including a test Jan 19, 2017

@Habbie

This comment has been minimized.

Show comment
Hide comment
@Habbie

Habbie Jan 20, 2017

Member

Ready for review.

Member

Habbie commented Jan 20, 2017

Ready for review.

@zeha

This comment has been minimized.

Show comment
Hide comment
@zeha

zeha Jan 21, 2017

Collaborator

lgtm

Collaborator

zeha commented Jan 21, 2017

lgtm

@pieterlexis pieterlexis merged commit 0d976cc into PowerDNS:master Feb 21, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

pieterlexis added a commit to pieterlexis/pdns that referenced this pull request Nov 7, 2017

@Habbie Habbie deleted the Habbie:ldap-ptr-fix branch Nov 9, 2017

pieterlexis added a commit to pieterlexis/pdns that referenced this pull request Nov 13, 2017

@zeha zeha referenced this pull request Dec 28, 2017

Merged

ldapbackend: fix listing zones incl. AXFR #6122

1 of 6 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment