Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Fix API performance: one DNSSECKeeper per request #4944
getZoneInfo() was instantiating a new DNSSECKeeper for every call. Since
This is fixed by passing a DNSSECKeeper instance to getZoneInfo().
@zeha The flag is currently being used. Removing it and requiring applications that need it for whatever reason to do individual calls for every single zone would not improve overal performance of the API.
How about adding an
Such a change would be breaking for applications that use this field, but they can easily be fixed by adding the
One way to keep it backward compatible is to default to
Based on my personal quick testing removing the field improves performance by 10-15% after this patch. This is significant enough to provide a way to not incur the overhead, but not to completely remove the functionality.