New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

recursor: use explicit yes for default-enabled settings #4960

Merged
merged 1 commit into from Feb 17, 2017

Conversation

Projects
None yet
4 participants
@zeha
Collaborator

zeha commented Jan 31, 2017

Short description

Some settings in the recursor default to enabled, but use an empty string to indicate that.
I've repeatedly been confused about those defaults when looking at the generated config file, so having them say foo=yes instead of foo= would make my life easier.

This should not include any actual logic or default changes.

Checklist

I have:

  • read the CONTRIBUTING.md document
  • compiled and tested this code
  • included documentation (including possible behaviour changes)
  • documented the code
  • added regression tests
  • added unit tests

@pieterlexis pieterlexis merged commit 825c2c6 into PowerDNS:master Feb 17, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

rgacogne added a commit to rgacogne/pdns that referenced this pull request Nov 13, 2017

@rgacogne rgacogne referenced this pull request Nov 13, 2017

Merged

Recursor 4.0.7 backports #5952

3 of 7 tasks complete

@zeha zeha deleted the zeha:default-settings branch Jan 29, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment