New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lowercase the TSIG algorithm name in hash computation #4961

Merged
merged 1 commit into from Feb 2, 2017

Conversation

Projects
None yet
2 participants
@rgacogne
Member

rgacogne commented Jan 31, 2017

Short description

RFC2845 states that the algorithm name should be in canonical wire format for the hash computation, which implies it should be lowercased. We actually did lowercase it in 3.x, until it was moved to a DNSName in 4.x.

Should fix #4942, thanks @wsanders for the investigative work!

This PR should also add some unit and/or regression tests.

Checklist

I have:

  • read the CONTRIBUTING.md document
  • compiled and tested this code
  • included documentation (including possible behaviour changes)
  • documented the code
  • added regression tests
  • added unit tests
Lowercase the TSIG algorithm name in hash computation
`RFC2845` states that the algorithm name should be in `canonical wire
format` for the hash computation, which implies it should be lowercased.
We actually did lowercase it in 3.x, until it was moved to a `DNSName`
in 4.x.

@pieterlexis pieterlexis merged commit 34cca5b into PowerDNS:master Feb 2, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@rgacogne rgacogne deleted the rgacogne:tsig-canonical-algo branch Feb 2, 2017

ahupowerdns added a commit that referenced this pull request Feb 10, 2017

Merge pull request #4971 from rgacogne/auth40-tsig-canonical-algo
Backport #4961: Lowercase the TSIG algorithm name in hash computation

pieterlexis added a commit that referenced this pull request Feb 17, 2017

Merge pull request #4970 from rgacogne/rec40-tsig-canonical-algo
Backport #4961: Lowercase the TSIG algorithm name in hash computation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment