New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: PowerDNS Forward-Notify Patch #4965

Merged
merged 6 commits into from Jun 13, 2017

Conversation

Projects
None yet
4 participants
@DrRemorse

DrRemorse commented Feb 1, 2017

Short description

This patch will allow you to redirect inbound notifications to a proxy server. It's intended use is in anycast environments where it might be necessary for a proxy server to preform the AXFR.

The configuration option "forward-notify" has been added to the pdns.conf parser. The option accepts multiple IPv4 and IPv6 address values.

Obsoletes #4964

Checklist

I have:

  • read the CONTRIBUTING.md document
  • compiled and tested this code
  • included documentation (including possible behaviour changes)
  • documented the code
  • added regression tests
  • added unit tests
  • checked that this code was merged to master

@DrRemorse DrRemorse changed the title from PowerDNS Forward-Notify Patch to Feature request: PowerDNS Forward-Notify Patch Feb 8, 2017

@Habbie Habbie added this to the auth-4.1.0 milestone Apr 3, 2017

@Habbie

I see no problems with this PR, the refactor would be nice to have.

If you add this feature to the documentation (in docs/markdown) I am happy to merge this.

Show outdated Hide outdated pdns/communicator.cc
@@ -53,6 +53,8 @@
AtomicCounter PacketHandler::s_count;
NetmaskGroup PacketHandler::s_allowNotifyFrom;
set<string> PacketHandler::s_forwardNotify;

This comment has been minimized.

@Habbie

Habbie Apr 7, 2017

Member

Why is this string and not ComboAddress?

@Habbie

Habbie Apr 7, 2017

Member

Why is this string and not ComboAddress?

This comment has been minimized.

@Habbie

Habbie Apr 7, 2017

Member

Ah, because d_alsoNotify works like that. Not your fault then.

@Habbie

Habbie Apr 7, 2017

Member

Ah, because d_alsoNotify works like that. Not your fault then.

@Habbie

This comment has been minimized.

Show comment
Hide comment
@Habbie

Habbie Apr 7, 2017

Member

Reviewed. I took the liberty of unchecking two checkboxes that were erroneously checked.

Member

Habbie commented Apr 7, 2017

Reviewed. I took the liberty of unchecking two checkboxes that were erroneously checked.

Ralph Covelli added some commits Apr 25, 2017

Ralph Covelli
PowerDNS Forward-Notify Patch:
This patch will allow you to redirect inbound notifications to a proxy server.  It's intended use is in anycast environments where it might be necessary for a proxy server to preform the AXFR.

The configuration option "forward-notify" has been added to the pdns.conf parser. The option accepts multiple IPv4 and IPv6 address values.
Show outdated Hide outdated pdns/communicator.cc
@Habbie

Should be good after these changes.

Show outdated Hide outdated pdns/communicator.cc
Show outdated Hide outdated docs/markdown/authoritative/settings.md
Show outdated Hide outdated docs/markdown/authoritative/settings.md
@Habbie

Habbie approved these changes Jun 12, 2017

One final nit (the uppercase L). Good to merge when that is fixed.

Show outdated Hide outdated pdns/communicator.hh

@Habbie Habbie merged commit b43671d into PowerDNS:master Jun 13, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment