New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dnsdist: Don't cache answers without any TTL #4987

Merged
merged 1 commit into from Feb 9, 2017

Conversation

Projects
None yet
2 participants
@rgacogne
Member

rgacogne commented Feb 8, 2017

Short description

RFC2308 states that:

negative responses without SOA records SHOULD NOT be cached as there is no way to prevent the negative responses looping forever between a pair of servers even with a short TTL".

Fixes #4983.

Checklist

I have:

  • read the CONTRIBUTING.md document
  • compiled and tested this code
  • included documentation (including possible behaviour changes)
  • documented the code
  • added regression tests
  • added unit tests
dnsdist: Don't cache answers without any TTL
`RFC2308` states that "negative responses without SOA records SHOULD
NOT be cached as there is no way to prevent the negative responses
looping forever between a pair of servers even with a short TTL".

@ahupowerdns ahupowerdns merged commit cab90c2 into PowerDNS:master Feb 9, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@rgacogne rgacogne deleted the rgacogne:dnsdist-prevent-caching-no-ttl branch Feb 9, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment