New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix remotebackend params #4997

Merged
merged 4 commits into from Feb 20, 2017

Conversation

Projects
None yet
4 participants
@cmouse
Contributor

cmouse commented Feb 12, 2017

Short description

Fix two problems with remotebackend

  • list method used domain-id json parameter, when it was supposed to use domain_id
  • NULL ordername was not passed as empty string in POST parameters builder, instead it threw exception

Checklist

I have:

  • read the CONTRIBUTING.md document
  • compiled and tested this code
  • included documentation (including possible behaviour changes)
  • documented the code
  • added regression tests
  • added unit tests

@pieterlexis pieterlexis merged commit b961df4 into PowerDNS:master Feb 20, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

pieterlexis added a commit to pieterlexis/pdns that referenced this pull request Nov 7, 2017

pieterlexis added a commit to pieterlexis/pdns that referenced this pull request Nov 13, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment