Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactoring of the TSIG handling #5003

Merged
merged 1 commit into from Feb 21, 2017
Merged

Refactoring of the TSIG handling #5003

merged 1 commit into from Feb 21, 2017

Conversation

rgacogne
Copy link
Member

Short description

Refactoring of the TSIG handling:

  • Merge all the TSIG checks into validateTSIG() to remove code duplication and make it easier to audit
  • Add unit tests

Closes #4968.

Checklist

I have:

  • read the CONTRIBUTING.md document
  • compiled and tested this code
  • included documentation (including possible behaviour changes)
  • [] documented the code
  • added regression tests
  • added unit tests

@rgacogne
Refactoring of the TSIG handling
ea3816c 
* Merge all the TSIG checks into `validateTSIG()` to remove
code duplication and make it easier to audit
* Add unit tests
@pieterlexis pieterlexis merged commit 45879fa into PowerDNS:master Feb 21, 2017
@rgacogne rgacogne deleted the tsig-tests branch February 21, 2017 22:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
auth needs review rec
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add unit-tests for tsig
2 participants
@rgacogne @pieterlexis