New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API: Allow setting extra domain metadata #5038

Merged
merged 1 commit into from Feb 20, 2017

Conversation

Projects
None yet
3 participants
@pieterlexis
Member

pieterlexis commented Feb 15, 2017

Short description

This allows setting domain metadata starting with "X-" via the API.

This will allow external applications to store data related to domains.

Checklist

I have:

  • read the CONTRIBUTING.md document
  • compiled and tested this code
  • included documentation (including possible behaviour changes)
  • documented the code
  • added regression tests
  • added unit tests
@Habbie

Habbie approved these changes Feb 15, 2017

Show outdated Hide outdated docs/markdown/authoritative/domainmetadata.md Outdated
@zeha

zeha approved these changes Feb 15, 2017

I feel uneasy about storing these in the domainmetadata table (or whatever the backends equiv) is and also exposing it in this straight forward way.
Code LGTM.

@zeha

This comment has been minimized.

Show comment
Hide comment
@zeha

zeha Feb 15, 2017

Collaborator

Nit: update API docs too?

Collaborator

zeha commented Feb 15, 2017

Nit: update API docs too?

@pieterlexis

This comment has been minimized.

Show comment
Hide comment
@pieterlexis

pieterlexis Feb 17, 2017

Member

@zeha a way to fix this is creating a way to authorize different metadata based on the api-key used, that would require some infrastructure in the server.

I would prefer recommending a light-weight proxy that does this authorization

Member

pieterlexis commented Feb 17, 2017

@zeha a way to fix this is creating a way to authorize different metadata based on the api-key used, that would require some infrastructure in the server.

I would prefer recommending a light-weight proxy that does this authorization

API: Allow setting extra domain metadata
This allows setting domain metadata starting with "X-".
@zeha

zeha approved these changes Feb 17, 2017

@pieterlexis pieterlexis merged commit 60de167 into PowerDNS:master Feb 20, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@pieterlexis pieterlexis deleted the pieterlexis:API-allow-X-metadata branch Feb 20, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment