Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

StateHolder: Allocate (and copy if needed) before taking the lock #5042

Merged
merged 1 commit into from Feb 20, 2017
Merged

StateHolder: Allocate (and copy if needed) before taking the lock #5042

merged 1 commit into from Feb 20, 2017

Conversation

rgacogne
Copy link
Member

Short description

No need to block the other processes while we allocate memory and duplicate the content if needed. That might take a -relatively- long time for large objects like the filter policies contained in the LuaConfigItems object.

Checklist

I have:

  • read the CONTRIBUTING.md document
  • compiled and tested this code
  • included documentation (including possible behaviour changes)
  • documented the code
  • added or modified regression test(s)
  • added or modified unit test(s)

@ahupowerdns ahupowerdns merged commit 4be29d4 into PowerDNS:master Feb 20, 2017
@rgacogne rgacogne deleted the state-holder-allocate-and-copy-before-lock branch February 20, 2017 14:52
Habbie added a commit that referenced this pull request Mar 20, 2017
@Habbie
Merge pull request #5166 from rgacogne/rec40-backport-5042
d57f058 
Backport #5042: StateHolder: Allocate (and copy if needed) before taking the lock
@mind04 mind04 mentioned this pull request May 5, 2017
Merged
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
auth dnsdist enhancement rec
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@rgacogne @ahupowerdns