New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

backport #4744: Handle exceptions raised by `closesocket()` #5048

Merged
merged 1 commit into from Feb 17, 2017

Conversation

Projects
None yet
2 participants
@rgacogne
Member

rgacogne commented Feb 16, 2017

Short description

This was not very well handled, and could cause the PowerDNS process to terminate. This is especially nasty when closesocket() is called from a destructor, as we could already be dealing with an exception.

(cherry picked from commit a7b68ae)

Checklist

I have:

  • read the CONTRIBUTING.md document
  • compiled and tested this code
  • included documentation (including possible behaviour changes)
  • documented the code
  • added or modified regression test(s)
  • added or modified unit test(s)
  • checked that this code was merged to master
Handle exceptions raised by `closesocket()`
This was not very well handled, and could cause the PowerDNS process
to terminate. This is especially nasty when `closesocket()` is called
from a destructor, as we could already be dealing with an exception.

(cherry picked from commit a7b68ae)

@pieterlexis pieterlexis merged commit e7c33ed into PowerDNS:rel/auth-4.0.x Feb 17, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@rgacogne rgacogne deleted the rgacogne:auth40-backport-4744 branch Feb 17, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment