New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FreeBSD build notes and compile fixes. #5067

Merged
merged 2 commits into from Mar 17, 2017

Conversation

Projects
None yet
3 participants
@cynthia
Copy link
Contributor

cynthia commented Feb 22, 2017

Short description

This adds a note for building on FreeBSD and fixes a compile error in json11.cpp.

It might make sense to look into setting c++11 for clang instead of gnuc++11 under clang, but the regression scope of that is a bit unclear due to the amount of versions of XCode and FreeBSD releases (each running different versions of clang!) out in the wild.

For the time being, I felt the safer route was to document a flag override only for FreeBSD, as that makes the regression surface minimal to non-existent.

Checklist

I have:

  • read the CONTRIBUTING.md document
  • compiled and tested this code
  • included documentation (including possible behaviour changes)
  • documented the code
  • added or modified regression test(s)
  • added or modified unit test(s)

The one liner include change should have no side effects, so I have omitted extra tests to cover this.

@rgacogne

This comment has been minimized.

Copy link
Member

rgacogne commented Mar 1, 2017

Thank you for this PR! Just one thing, it would be nice if the header addition to json.cpp could be fixed upstream at https://github.com/dropbox/json11, would you mind opening a PR there?

@pieterlexis pieterlexis merged commit 46d1612 into PowerDNS:master Mar 17, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment