New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix a regression in axfr-rectify #5083

Closed
wants to merge 2 commits into
base: master
from

Conversation

Projects
None yet
3 participants
@mind04
Contributor

mind04 commented Feb 24, 2017

Short description

fix a regression in axfr-rectify introduced by commit d86e1bf and a minor cleanup

Checklist

I have:

  • read the CONTRIBUTING.md document
  • compiled and tested this code
  • included documentation (including possible behaviour changes)
  • documented the code
  • added or modified regression test(s)
  • added or modified unit test(s)
@Habbie

This comment has been minimized.

Show comment
Hide comment
@Habbie

Habbie Feb 28, 2017

Member

No test? What was the regression?

Member

Habbie commented Feb 28, 2017

No test? What was the regression?

@mind04

This comment has been minimized.

Show comment
Hide comment
@mind04

mind04 Feb 28, 2017

Contributor

This line d86e1bf#diff-3917c8ff4981aace2d1a73b0a7588abdL750 was moved. This is bypassing the removal of ents here d86e1bf#diff-3917c8ff4981aace2d1a73b0a7588abdR763 This result in additional nsec3 records for unauth ents.

Test could be AXFR of an unrectified nsec3 optout dnssec-parent.com zone with axfr-rectify enabled. But my time is limited atm so I pass this part to someone else.

Contributor

mind04 commented Feb 28, 2017

This line d86e1bf#diff-3917c8ff4981aace2d1a73b0a7588abdL750 was moved. This is bypassing the removal of ents here d86e1bf#diff-3917c8ff4981aace2d1a73b0a7588abdR763 This result in additional nsec3 records for unauth ents.

Test could be AXFR of an unrectified nsec3 optout dnssec-parent.com zone with axfr-rectify enabled. But my time is limited atm so I pass this part to someone else.

baloo added a commit to baloo/pdns that referenced this pull request Mar 15, 2017

Implement test for #5083
Signed-off-by: Arthur Gautier <baloo@gandi.net>

@baloo baloo referenced this pull request Mar 15, 2017

Merged

fix a regression in axfr-rectify + test #5161

3 of 7 tasks complete

baloo added a commit to baloo/pdns that referenced this pull request Mar 15, 2017

Implement test for #5083
Signed-off-by: Arthur Gautier <baloo@gandi.net>

baloo added a commit to baloo/pdns that referenced this pull request Mar 15, 2017

Implement test for #5083
Signed-off-by: Arthur Gautier <baloo@gandi.net>

baloo added a commit to baloo/pdns that referenced this pull request Apr 10, 2017

Implement test for #5083
Signed-off-by: Arthur Gautier <baloo@gandi.net>

baloo added a commit to baloo/pdns that referenced this pull request Apr 10, 2017

Implement test for #5083
Signed-off-by: Arthur Gautier <baloo@gandi.net>

baloo added a commit to baloo/pdns that referenced this pull request Apr 10, 2017

Implement test for #5083
Signed-off-by: Arthur Gautier <baloo@gandi.net>

baloo added a commit to baloo/pdns that referenced this pull request Apr 10, 2017

Implement test for #5083
Signed-off-by: Arthur Gautier <baloo@gandi.net>

baloo added a commit to baloo/pdns that referenced this pull request Apr 10, 2017

Implement test for #5083
Signed-off-by: Arthur Gautier <baloo@gandi.net>

baloo added a commit to baloo/pdns that referenced this pull request Apr 11, 2017

Implement test for #5083
Signed-off-by: Arthur Gautier <baloo@gandi.net>

baloo added a commit to baloo/pdns that referenced this pull request Apr 11, 2017

Implement test for #5083
Signed-off-by: Arthur Gautier <baloo@gandi.net>

baloo added a commit to baloo/pdns that referenced this pull request Apr 11, 2017

Implement test for #5083
Signed-off-by: Arthur Gautier <baloo@gandi.net>

baloo added a commit to baloo/pdns that referenced this pull request Apr 12, 2017

Implement test for #5083
Signed-off-by: Arthur Gautier <baloo@gandi.net>

baloo added a commit to baloo/pdns that referenced this pull request Apr 12, 2017

Implement test for #5083
Signed-off-by: Arthur Gautier <baloo@gandi.net>

baloo added a commit to baloo/pdns that referenced this pull request Apr 12, 2017

Implement test for #5083
Signed-off-by: Arthur Gautier <baloo@gandi.net>

baloo added a commit to baloo/pdns that referenced this pull request Apr 12, 2017

Implement test for #5083
Signed-off-by: Arthur Gautier <baloo@gandi.net>

@mind04 mind04 referenced this pull request May 5, 2017

Merged

Backport to stable #5297

3 of 7 tasks complete

baloo added a commit to baloo/pdns that referenced this pull request May 9, 2017

Implement test for #5083
Signed-off-by: Arthur Gautier <baloo@gandi.net>

baloo added a commit to baloo/pdns that referenced this pull request May 10, 2017

Implement test for #5083
Signed-off-by: Arthur Gautier <baloo@gandi.net>

baloo added a commit to baloo/pdns that referenced this pull request May 11, 2017

Implement test for #5083
Signed-off-by: Arthur Gautier <baloo@gandi.net>
@mind04

This comment has been minimized.

Show comment
Hide comment
@mind04

mind04 May 11, 2017

Contributor

included in #5161

Contributor

mind04 commented May 11, 2017

included in #5161

@mind04 mind04 closed this May 11, 2017

@mind04 mind04 deleted the mind04:axfr-rectify branch May 11, 2017

pieterlexis added a commit to pieterlexis/pdns that referenced this pull request Nov 3, 2017

Implement test for #5083
Signed-off-by: Arthur Gautier <baloo@gandi.net>
(cherry picked from commit 3adde0d)

pieterlexis added a commit to pieterlexis/pdns that referenced this pull request Nov 7, 2017

Implement test for #5083
Signed-off-by: Arthur Gautier <baloo@gandi.net>
(cherry picked from commit 3adde0d)

pieterlexis added a commit to pieterlexis/pdns that referenced this pull request Nov 7, 2017

Implement test for #5083
Signed-off-by: Arthur Gautier <baloo@gandi.net>
(cherry picked from commit 3adde0d)

pieterlexis added a commit to pieterlexis/pdns that referenced this pull request Nov 7, 2017

Implement test for #5083
Signed-off-by: Arthur Gautier <baloo@gandi.net>
(cherry picked from commit 3adde0d)

pieterlexis added a commit to pieterlexis/pdns that referenced this pull request Nov 13, 2017

Implement test for #5083
Signed-off-by: Arthur Gautier <baloo@gandi.net>
(cherry picked from commit 3adde0d)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment