Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LuaWrapper: Allow embedded NULs in strings received from Lua #5147

Merged
merged 1 commit into from
Mar 15, 2017
Merged

LuaWrapper: Allow embedded NULs in strings received from Lua #5147

merged 1 commit into from
Mar 15, 2017

Conversation

Habbie
Copy link
Member

@Habbie Habbie commented Mar 14, 2017 •
edited
Loading

Short description

This stops LuaWrapper from truncating strings received from Lua at the first sighting of NUL.

Checklist

I have:

  • read the CONTRIBUTING.md document
  • compiled and tested this code
  • included documentation (including possible behaviour changes)
  • documented the code
  • added or modified regression test(s)
  • added or modified unit test(s)
  • checked that this code was merged to master

@rgacogne rgacogne merged commit 0ad4d08 into PowerDNS:master Mar 15, 2017
@Habbie Habbie deleted the lua-string-nul branch March 15, 2017 09:07
pieterlexis added a commit to pieterlexis/pdns that referenced this pull request May 9, 2017
@pieterlexis
Recursor: Backport PowerDNS#5147
492222b
@pieterlexis pieterlexis mentioned this pull request May 9, 2017
Merged
7 tasks
pieterlexis added a commit to pieterlexis/pdns that referenced this pull request Nov 7, 2017
@pieterlexis
Backport PowerDNS#5147
3d86055
pieterlexis added a commit to pieterlexis/pdns that referenced this pull request Nov 13, 2017
@pieterlexis
Backport PowerDNS#5147
c973c6e
This was referenced Nov 13, 2017
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rgacogne rgacogne rgacogne approved these changes

Assignees
No one assigned
Labels
auth dnsdist rec
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Habbie @rgacogne