New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ALIAS: disable expansion by default #5182

Merged
merged 1 commit into from Mar 21, 2017

Conversation

Projects
None yet
2 participants
@pieterlexis
Member

pieterlexis commented Mar 20, 2017

Short description

Closes #5119

Checklist

I have:

  • read the CONTRIBUTING.md document
  • compiled and tested this code
  • included documentation (including possible behaviour changes)
  • documented the code
  • added or modified regression test(s)
  • added or modified unit test(s)

@pieterlexis pieterlexis added the auth label Mar 20, 2017

@Habbie

Habbie approved these changes Mar 20, 2017

Show outdated Hide outdated docs/markdown/authoritative/settings.md
Show outdated Hide outdated docs/markdown/authoritative/howtos.md
@@ -108,6 +108,7 @@ private:
bool d_logDNSDetails;
bool d_doIPv6AdditionalProcessing;
bool d_doDNAME;
bool d_doExpandALIAS;

This comment has been minimized.

@Habbie

Habbie Mar 20, 2017

Member

I wonder if these flags, in general, shouldn't be static so we just parse them once on startup. Not a job for this PR though.

@Habbie

Habbie Mar 20, 2017

Member

I wonder if these flags, in general, shouldn't be static so we just parse them once on startup. Not a job for this PR though.

@Habbie Habbie merged commit 3aab2eb into PowerDNS:master Mar 21, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@pieterlexis pieterlexis deleted the pieterlexis:issue-5119-disable-ALIAS branch Mar 21, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment