New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjustable statistics interval #5190

Closed
wants to merge 162 commits into
base: master
from

Conversation

Projects
None yet
@phonedph1
Contributor

phonedph1 commented Mar 22, 2017

Short description

Quick fix for #3781

Not sure if this should say "at most" since it's dependent on amount of queries coming in.

Checklist

I have:

  • read the CONTRIBUTING.md document
  • compiled and tested this code
  • included documentation (including possible behaviour changes)
  • documented the code
  • added or modified regression test(s)
  • added or modified unit test(s)

goestreicher and others added some commits Sep 14, 2016

Refactor the LDAP backend.
This prepares the future work on this backend.
Add the LDAP simple authenticator.
All authentication work will be delegated to an implementation of
the LdapAuthenticator pure abstract class. The first authenticator
is here to support the classical password bind.
Add LDAP GSSAPI authenticator.
Also add in the LDAP backend docs the new configuration settings
to use it.
Try to reconnect to LDAP when connection is lost
Actually this will only work for initial lookup()
and list() calls. If the connection is dropped
between one of those and get() the request will
fail.
auth: Hash the entire query in the packet cache, split caches
* The packet cache now behaves a lot like the ones in dnsdist and
the recursor, hashing the entire query (except the query id)
to prevent matching queries with, for example, different EDNS version.
* Since the packet and query caches have now much less in common, split
them into two different classes since it doesn't make sense to share
the same storage and maximum number of entries and doing so clarifies
the code a lot. This should also reduce contention.
* Add a new `max-packet-cache-entries` setting to control the number of
entries in the packet cache.
* Add a new metric, `query-cache-size`, the number of entries
in the query cache since `packetcache-size` is only about the packet
cache.

Note that contrary to the recursor one's, the new packet cache doesn't
skip the content of an EDNS Client Subnet option if present, in case it's
used by a backend to produce the response. We could easily change that, or
even make it configurable if we care.
Stubresolver: Use only `resolver` setting if given
Use resolv.conf otherwise. Also, do not use 127.0.0.1:53 as fallback,
as this could be ourselves.

Closes #4655
dnsdist: Fix destination port reporting on "any" binds
Over UDP we call `HarvestDestinationAddress()` to get the real
destination address via `IP_PKTINFO`., but this only sets the destination
address, not the destination port. Therefore since
7cea4e39a78ef981ee461b49bbc193fa9903f56dit the destination port was always
0 when bound to an "any" address.
setKey() was actually "appendKey()". In addition, '-k' would not over…
…ride for server configuration. Unified -k behaviour for client and server mode now.
Merge pull request #5192 from 0xf3f/master
Fix wrong launch/module name in PostgreSQL 4.x auth docs
rec: Allow access to EDNS options from the `gettag()` hook
If `gettag-needs-edns-options` is set, the EDNS options are extracted
and passed to the `gettag()` hook as a table whose keys are the
EDNS option code and the values are `EDNSOptionView` object.
`EDNSOptionView` has two members, `content` and `size`, with `content`
holding the raw, undecoded option value.
Merge pull request #5197 from nivex/zone-count-verbose
pdnsutil: Only print zonecount if invoked verbose
Fix misc/exception.hpp include condition
luawrapper 93ab8b23 2d6e90a2
don't move return value
luawrapper 6a6c672
fix unused parameter warnings by commenting names
fix unused nullptr_t parameter warning

luawrapper 4901e73 2e21101
Merge pull request #5198 from rgacogne/rec-gettag-edns-options
rec: Allow access to EDNS options from the `gettag()` hook
Merge pull request #5194 from rgacogne/dnsdist-fix-dest-port-when-har…
…vesting

dnsdist: Fix destination port reporting on "any" binds

rgacogne and others added some commits Apr 14, 2017

Merge pull request #5239 from rgacogne/dnsdist-debug-dynblocks-failures
dnsdist: Add some debug to the DynBlocks regression tests
dnsdist: Stop sending queries as soon as we are dyn-blocked in tests
Otherwise we might take too much time to finish sending our queries
(2s timeout per query), ending up with the dynamic block rule gone
by the time we finish.
Merge pull request #5244 from rgacogne/dnsdist-stop-on-dynblock
dnsdist: Stop sending queries as soon as we are dyn-blocked in tests
move two other functions into ascii.hh
dns_isspace() and dns_toupper() are all functions operating upon ASCII
characters. So lets move them into ascii.hh and keep them together with
dns_tolower().
lua-auth: Drop axfrfilter
It's no longer needed.
Merge pull request #5185 from rgacogne/dnsdist-nmg-add-masks
dnsdist: Add `NetmaskGroup::addMasks()` to fill a NMG from `exceeds*` results
Merge pull request #5253 from ahupowerdns/dnsdist-verbosepro
add some better dnsdist -v logging on queries that get dropped, timed out or received
Merge pull request #5249 from tfarina/dns-ascii
move two other functions into ascii.hh
Merge pull request #5254 from pieterlexis/pkg-snmp-support
Packages: Build with net-snmp support and against LuaJIT
Merge pull request #5250 from cmouse/axfrfilter
Implement axfrfilter with LuaContext
Merge pull request #5261 from percipient/json-stat-fix
get-remote-ring's "other" report should only have two items.
* Default: 1800
* Available since: 4.1.0
Interval between logging statistical summary on recursor performance.

This comment has been minimized.

@Habbie

Habbie Apr 24, 2017

Member

Can you add 0 to disable here as well?

@Habbie

Habbie Apr 24, 2017

Member

Can you add 0 to disable here as well?

@Habbie

This comment has been minimized.

Show comment
Hide comment
@Habbie

Habbie Apr 24, 2017

Member

One nit, approved after that. Can you fix the nit and rebase?

Member

Habbie commented Apr 24, 2017

One nit, approved after that. Can you fix the nit and rebase?

@phonedph1

This comment has been minimized.

Show comment
Hide comment
@phonedph1

phonedph1 Apr 24, 2017

Contributor

Oh my goodness. I'll re-open this. I managed to get myself into git merge/rebase hell.

Contributor

phonedph1 commented Apr 24, 2017

Oh my goodness. I'll re-open this. I managed to get myself into git merge/rebase hell.

@phonedph1 phonedph1 closed this Apr 24, 2017

@phonedph1 phonedph1 referenced this pull request Apr 24, 2017

Merged

Adjustable statistics interval #5271

3 of 6 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment