Merged
Conversation
rgacogne
approved these changes
Apr 19, 2017
Member
rgacogne
left a comment
rgacogne
left a comment
There was a problem hiding this comment.
It would be nice to check that QNameRule("ds9a.nl.") does not match a query for "www.ds9a.nl." in the regression tests, but otherwise looks good.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Short description
This PR 1) adds an actual QNameRule that matches a single QName exactly 2) changes the SuffixMatchNode rule to no longer claim "qname ==" but now to say "qname in".
Checklist
I have: