Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dnsdist qnamerule #5235

Merged
merged 2 commits into from Apr 19, 2017
Merged

Conversation

ahupowerdns
Copy link
Contributor

@ahupowerdns ahupowerdns commented Apr 11, 2017

Short description

This PR 1) adds an actual QNameRule that matches a single QName exactly 2) changes the SuffixMatchNode rule to no longer claim "qname ==" but now to say "qname in".

Checklist

I have:

  • read the CONTRIBUTING.md document
  • compiled and tested this code
  • included documentation (including possible behaviour changes)
  • documented the code
  • added or modified regression test(s)
  • added or modified unit test(s)
  • checked that this code was merged to master

@ahupowerdns ahupowerdns requested a review from Habbie April 18, 2017 19:02
Copy link
Member

@rgacogne rgacogne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be nice to check that QNameRule("ds9a.nl.") does not match a query for "www.ds9a.nl." in the regression tests, but otherwise looks good.

@ahupowerdns ahupowerdns merged commit af7edbc into PowerDNS:master Apr 19, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants