New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement axfrfilter with LuaContext #5250

Merged
merged 4 commits into from Apr 21, 2017

Conversation

Projects
None yet
4 participants
@cmouse
Contributor

cmouse commented Apr 17, 2017

Short description

Implements axfrfilter using the new luacontext system. It also changes slightly how the AXFR filter works, by allowing the hook to also prepend records instead of just replacing them.

Checklist

I have:

  • read the CONTRIBUTING.md document
  • compiled and tested this code
  • included documentation (including possible behaviour changes)
  • documented the code
  • added or modified regression test(s)
  • added or modified unit test(s)

@cmouse cmouse changed the title from Axfrfilter to Implement axfrfilter with LuaContext Apr 17, 2017

@Habbie

Habbie approved these changes Apr 17, 2017

Show outdated Hide outdated pdns/lua-auth4.cc
Show outdated Hide outdated pdns/lua-auth4.cc
@@ -5,6 +5,7 @@
#include "dnsrecords.hh"
#include "dnspacket.hh"
#include <unordered_map>
#include <boost/variant/variant.hpp>

This comment has been minimized.

@Habbie

Habbie Apr 17, 2017

Member

This header is not used (but see ttl question above).

@Habbie

Habbie Apr 17, 2017

Member

This header is not used (but see ttl question above).

@Habbie

This comment has been minimized.

Show comment
Hide comment
@Habbie

Habbie Apr 17, 2017

Member

Approved with minor nits. As discussed on IRC, the return value could use some docs.

Member

Habbie commented Apr 17, 2017

Approved with minor nits. As discussed on IRC, the return value could use some docs.

@cmouse

This comment has been minimized.

Show comment
Hide comment
@cmouse

cmouse Apr 17, 2017

Contributor

i forgot to retest after latest change.

Contributor

cmouse commented Apr 17, 2017

i forgot to retest after latest change.

@cmouse

This comment has been minimized.

Show comment
Hide comment
@cmouse

cmouse Apr 17, 2017

Contributor

seems to work.

Contributor

cmouse commented Apr 17, 2017

seems to work.

@ahupowerdns ahupowerdns merged commit 39cab2d into PowerDNS:master Apr 21, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment