Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PowerDNS sdig does not truncate trailing bits of EDNS Client Subnet mask #5320

Merged
merged 1 commit into from May 13, 2017

Conversation

@ahupowerdns
Copy link
Member

ahupowerdns commented May 13, 2017

So if you'd truncate something as
a /9, we'd have to use 2 bytes anyhow, but we would not zero the last 7 bits.

We do now. Thanks Mukund & ISC!

Short description

Use ComboAddress::truncate logic.

Checklist

I have:

  • read the CONTRIBUTING.md document
  • compiled and tested this code
  • included documentation (including possible behaviour changes)
  • documented the code
  • added or modified regression test(s)
  • added or modified unit test(s)
  • checked that this code was merged to master
…uncate

trailing bits of EDNS Client Subnet mask.  So if you'd truncate something as
a /9, we'd have to use 2 bytes anyhow, but we would not zero the last 7 bits.

We do now. Thanks Mukund & ISC!
@rgacogne
Copy link
Member

rgacogne commented May 13, 2017

Every single unit test falls on a byte boundary.. I'll have to add some to cover this case.

@rgacogne rgacogne merged commit c3b0dc6 into PowerDNS:master May 13, 2017
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@rgacogne rgacogne mentioned this pull request May 19, 2017
3 of 6 tasks complete
pieterlexis added a commit to pieterlexis/pdns that referenced this pull request Nov 7, 2017
pieterlexis added a commit to pieterlexis/pdns that referenced this pull request Nov 13, 2017
rgacogne added a commit to rgacogne/pdns that referenced this pull request Nov 13, 2017
@rgacogne rgacogne mentioned this pull request Nov 13, 2017
3 of 7 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.