Skip to content

PowerDNS sdig does not truncate trailing bits of EDNS Client Subnet mask - #5320

Merged
rgacogne merged 1 commit into
PowerDNS:masterfrom
ahupowerdns:edns-truncate
May 13, 2017
Merged

PowerDNS sdig does not truncate trailing bits of EDNS Client Subnet mask#5320
rgacogne merged 1 commit into
PowerDNS:masterfrom
ahupowerdns:edns-truncate

Conversation

@ahupowerdns

Copy link
Copy Markdown
Contributor

So if you'd truncate something as
a /9, we'd have to use 2 bytes anyhow, but we would not zero the last 7 bits.

We do now. Thanks Mukund & ISC!

Short description

Use ComboAddress::truncate logic.

Checklist

I have:

  • read the CONTRIBUTING.md document
  • compiled and tested this code
  • included documentation (including possible behaviour changes)
  • documented the code
  • added or modified regression test(s)
  • added or modified unit test(s)
  • checked that this code was merged to master

…uncate

trailing bits of EDNS Client Subnet mask.  So if you'd truncate something as
a /9, we'd have to use 2 bytes anyhow, but we would not zero the last 7 bits.

We do now. Thanks Mukund & ISC!
@rgacogne

Copy link
Copy Markdown
Member

Every single unit test falls on a byte boundary.. I'll have to add some to cover this case.

@rgacogne
rgacogne merged commit c3b0dc6 into PowerDNS:master May 13, 2017
pieterlexis added a commit to pieterlexis/pdns that referenced this pull request Nov 7, 2017
pieterlexis added a commit to pieterlexis/pdns that referenced this pull request Nov 13, 2017
rgacogne added a commit to rgacogne/pdns that referenced this pull request Nov 13, 2017
@rgacogne rgacogne mentioned this pull request Nov 13, 2017
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants